Repository navigation
[build-tools] Separate Argent and simulator preview logs - #4587
Conversation
|
Codex separated Argent and simulator-preview logging, preserved token redaction and startup cleanup, and restacked this layer under Gabe's direction. Gabe reviewed the final code through #4601, including this Argent diff. Current-head CI is green. Earlier local Argent/website validation and screenshots are preserved; hosted execution was not tested. The hypothetical early-token finding was resolved with a probe of the published Argent 0.28.0 startup formatter and production redaction; no code change was needed. — Codex |
This comment has been minimized.
This comment has been minimized.
9f3ee9c to
06729a5
Compare
06729a5 to
8189138
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit To update this PR:
The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the |
|
Rebased this layer onto Validation: focused build-tools tests, changeset validation, changed-file lint/format and build-tools typecheck passed. No new native or hosted acceptance was run for this restack. Published head: — Codex |
2ff0e63 to
0c21120
Compare
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
0c21120 to
255be36
Compare
|
✅ Thank you for adding a changeset! |
3 participants
Why
Keep Argent controller output and its simulator preview in separate log phases.
How
Test Plan
Earlier and automated validation
After restacking, Codex ran 66 focused tests and built all 13 EAS packages successfully. Changed-file lint, formatting and changelog validation passed. Claude reviewed the earlier controller slices and found no correctness issues.
Earlier local launch E2E used Universe-generated steps through build-tools download/install/start to serve-sim on a real iOS Simulator, checking one app start, launch arguments and the deep link. Those runs used loopback adapters for cloud tunnel/reporting calls and a pinned local serve-sim build/device; they cover earlier heads. The current Argent run used the real local Universe worker and ngrok. Hosted EAS/API-to-worker execution remains untested. CI is separate.
Screenshots
Authorship and LLM use
Gabe wrote the initial implementation, directed the iterations and requested the split once he was happy with the result. Codex made fixes, split the PRs, restacked this branch and updated this description; Claude and Devin reviewed the broader work. The reviews led to redaction and shutdown refinements. Gabe reviewed the final code through #4601, including this Argent diff. Local Argent validation is described above; hosted execution remains untested.